perf: pre-compute ETag for /all/ endpoints#152
Merged
Conversation
Cache pre-serialized JSON bytes and their ETag at build time instead of storing raw Python dicts. On cache hit, return a pre-built HttpResponse with the ETag already set so ConditionalGetMiddleware can return 304 without any JSON serialization or MD5 hashing — dropping 304 latency from ~669ms to ~1ms. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpResponsewith the ETag already set soConditionalGetMiddlewarecan return 304 without any JSON serialization or MD5 hashing./api/titles/all/(and equivalently for/api/models/all/,/api/manufacturers/all/,/api/people/all/).list[dict]format (treats them as a cache miss and rebuilds).Test plan
TestConditionalGettests verify 304 on matching ETag, 200 on stale ETag, and cache formatcurl -v /api/titles/all/returnsETagheadercurl -v -H 'If-None-Match: <etag>' /api/titles/all/returns 304 in sub-10ms🤖 Generated with Claude Code