feat(navigation): add canonical file tree browser primitive#127
Merged
Conversation
f959289 to
48d44e8
Compare
48d44e8 to
0c718c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainas a canonical baseline navigation primitive.UnifiedIUR.Widgets.Navigation.file_tree_browser/1withattributes.file_treeand recursive folder/file-leaf normalization.:file_tree_browserout ofUnifiedIUR.Widgets.Components,UnifiedUi.WidgetComponents, andAshUI.WidgetComponents.Architecture Decisions
file_tree_browser, generic and repo-independent.:navigation, not layer shell/callout and not widget-component catalog.attributes.file_treewithtree_id,root_label,nodes,selected_path,default_expanded?,selection_intent, andtoggle_intent.selectionandchangeinteractions from semantic intents. It does not expose rawon_select/on_toggleevent names in canonical data.file_kind,language, andline_count; renderer-specific glyphs/markers/indent are local presentation concerns.Open Questions Answered
:tree_viewextension vs new kind: use a new baseline primitive. Filesystem navigation has different semantics from generic data trees.:navigation.file_kind/language/path.toggle_intent.Verification
Passing:
mix test packages/unified_iur/test/unified_iur/widgets/file_tree_browser_test.exs packages/unified_iur/test/unified_iur/widgets_test.exs packages/live_ui/test/live_ui/widgets/file_tree_browser_test.exs packages/live_ui/test/live_ui/renderer_test.exs packages/desktop_ui/test/desktop_ui/renderer_test.exs packages/elm_ui/test/elm_ui/renderer_test.exs test/ash_ui/resource/file_tree_browser_test.exs test/ash_ui/phase_31_package_boundary_test.exs test/ash_ui/phase_31_runtime_adapter_test.exsmix format --check-formatted <changed files>bash ./scripts/validate_specs_governance.shKnown unrelated checkout issue:
mix test packages/desktop_ui/test/desktop_ui/phase_eleven_integration_test.exsstill fails one existing release-readiness assertion becauseDesktopUi.Validatereports missing.spec/specs/desktop_ui/*and.spec/planning/desktop_ui/*traceability files in this checkout. The renderer coverage checks pass.Spec-loop tasks are not available in this checkout:
mix spec.prime,mix spec.next, andmix spec.checkall return task-not-found.