adds inequalities methods #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds get_inequalities methods to three Databricks data provider classes and includes some minor code formatting improvements. The main purpose is to enable access to inequalities data across different data provider implementations.
Key changes:
- Added
get_inequalities()method toDatabricksProvider,DatabricksNational, andDatabricksIcbclasses - Minor code formatting improvements (line consolidation and removal of duplicate code)
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/nhp/databricks/provider.py | Added get_inequalities() method and consolidated lambda function formatting |
| src/nhp/databricks/national.py | Added get_inequalities() method, consolidated formatting, and removed duplicate raise NotImplementedError |
| src/nhp/databricks/icb.py | Added get_inequalities() method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yiwen-h
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.