Merged
Conversation
The127
force-pushed
the
feat/user-client-create
branch
from
620cff9 to
d6f97d8
Compare
Wrap POST /api/virtual-servers/{vs}/users so callers (e.g. the portal
backend's approval flow) can create regular users via the Go client.
Mirrors the existing Application.Create pattern.
Adds a httptest unit test and an e2e spec that exercises Create + Get
against the real server with service-user auth, including a duplicate
username error path.
Signed-off-by: karo <karolin.kostial@gmail.com>
The127
force-pushed
the
feat/user-client-create
branch
from
d6f97d8 to
23d5cd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Create(ctx, api.CreateUserRequestDto) (api.CreateUserResponseDto, error)to theUserClientinterface. WrapsPOST /api/virtual-servers/{vs}/usersfollowing the existingApplication.Createpattern.tests/e2e/userclient_test.go,//go:build e2e) that exercises create + get against the real server with service-user auth, plus a duplicate-username error path.Motivated by the portal backend's upcoming access-request approval flow, which needs to provision regular users via the Go client.
Test plan