feat: expose service-user key management over HTTP#274
Merged
Conversation
- POST /users/service-users/{id}/keys now honors an optional `kid` in
the request body, passing it through to the Associate command so
callers can pin a key id they control.
- Wire DELETE /users/service-users/{id}/keys/{kid}, backed by the
existing RemoveServiceUserPublicKey command (now keyed by kid
instead of public-key PEM).
- UserClient gains DTO-in/DTO-out Associate and a RemoveServiceUserPublicKey
method, matching the shape of the other client methods.
- Unit tests for both client methods; e2e spec covering caller-supplied
kid, server-generated kid, and remove.
Signed-off-by: karo <karolin.kostial@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /users/service-users/{id}/keysnow honors an optional `kid` in the request body; the Associate command already supported it, the HTTP layer was dropping it.Unblocks the keyline-operator's upcoming BYO-public-key CRD.
Breaking change
The client's `AssociateServiceUserPublicKey` signature now takes a request DTO instead of `(serviceUserID, publicKeyPEM)`. One known downstream caller (keyline-operator) will need a matching bump.
Test plan