Skip to content

fix(login): use system identity in ResetTemporaryPassword mediator call #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
The127 merged 1 commit into from
Apr 25, 2026
Merged

fix(login): use system identity in ResetTemporaryPassword mediator call #276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/handlers/login.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import (
"errors"
"fmt"
"github.com/The127/Keyline/config"
"github.com/The127/Keyline/internal/authentication"
"github.com/The127/Keyline/internal/commands"
"github.com/The127/Keyline/internal/database"
"github.com/The127/Keyline/internal/jsonTypes"
Expand Down Expand Up @@ -621,8 +622,14 @@ func ResetTemporaryPassword(w http.ResponseWriter, r *http.Request) {
return err
}

// The login flow is pre-authentication, so /logins/* skips
// authentication.Middleware and ctx carries no CurrentUser. Switch
// to the system identity for this command: the login token plus the
// LoginStepTemporaryPassword guard above are the proof that the
// caller is authorised to reset their own temp password.
sysCtx := authentication.ContextWithCurrentUser(ctx, authentication.SystemUser())
m := ioc.GetDependency[mediatr.Mediator](scope)
_, err = mediatr.Send[*commands.SetPasswordResponse](ctx, m, commands.SetPassword{
_, err = mediatr.Send[*commands.SetPasswordResponse](sysCtx, m, commands.SetPassword{
UserId: loginInfo.UserId,
NewPassword: dto.NewPassword,
Temporary: false,
Expand Down