Skip to content

Conversation

@reima
Copy link
Contributor

@reima reima commented Oct 2, 2022

This PR adds tests and documentation for all methods in the Utilities namespace.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md

@reima reima requested a review from siriak as a code owner October 2, 2022 14:25
@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 95.40% // Head: 95.47% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (317e883) compared to base (a9fa9bf).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
+ Coverage   95.40%   95.47%   +0.07%     
==========================================
  Files         192      192              
  Lines        8373     8373              
==========================================
+ Hits         7988     7994       +6     
+ Misses        385      379       -6     
Impacted Files Coverage Δ
Utilities/Extensions/DictionaryExtensions.cs 100.00% <ø> (ø)
Utilities/Extensions/RandomExtensions.cs 100.00% <ø> (ø)
Algorithms/Sorters/Comparison/TimSorter.cs 96.05% <0.00%> (+0.56%) ⬆️
Utilities/Extensions/VectorExtensions.cs 100.00% <0.00%> (+5.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot!

@siriak siriak enabled auto-merge (squash) October 4, 2022 10:58
@siriak siriak merged commit 5831b7d into TheAlgorithms:master Oct 4, 2022
@reima reima deleted the utilities-tests-and-docs branch October 4, 2022 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants