Skip to content

Conversation

@XenoxJeager
Copy link

@XenoxJeager XenoxJeager commented Oct 29, 2022

Description of Change

Contribution of an algorithm to calculate subnet mask of ipv4 addresses with network bits.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

/**
* @file
* @brief
* [Explanation](https://www.softwaretestinghelp.com/subnet-mask-and-network-classes/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a brief explanation of the algorithm/implementation.

Comment on lines +20 to +21
unsigned int ipv4;
unsigned char subnetmask[4];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a one-line description of what the variable is for (see the example below).

int64_t data = 0;       ///< The value/key of the node.
int64_t array[64];      ///< The array that will be used for the tree.

Comment on lines +43 to +46
/**
* @brief test method
*
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* @brief test method
*
*/
/**
* @brief Self-test implementations
* @returns void
*/

Comment on lines +56 to +59
int main()
{
test();
return 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int main()
{
test();
return 1;
/**
* @brief Main function
* @returns 0 on exit
*/
int main()
{
test(); // run self-test implementations
return 0;

@Panquesito7 Panquesito7 added enhancement New feature or request Changes requested labels Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Dec 8, 2022
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants