Skip to content

fix: hexadecimal_to_octal.c#1336

Closed
HarshitVashisht11 wants to merge 1 commit intoTheAlgorithms:masterfrom
HarshitVashisht11:patch-1
Closed

fix: hexadecimal_to_octal.c#1336
HarshitVashisht11 wants to merge 1 commit intoTheAlgorithms:masterfrom
HarshitVashisht11:patch-1

Conversation

@HarshitVashisht11
Copy link
Copy Markdown

@HarshitVashisht11 HarshitVashisht11 commented Oct 4, 2023

Description of Change

Fix to Issue #1330
I've made the following changes:

  • Removed the newline character from the input string.

  • Improved the binary to octal conversion loop.

  • Added a return statement after printing an error message for invalid hexadecimal input.

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@sk-jiyad
Copy link
Copy Markdown

sk-jiyad commented Oct 4, 2023

Is it running?

@HarshitVashisht11
Copy link
Copy Markdown
Author

Yes it is running

@sk-jiyad
Copy link
Copy Markdown

sk-jiyad commented Oct 9, 2023

No, it's not

@HarshitVashisht11
Copy link
Copy Markdown
Author

It's working, can you specify the problem

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 9, 2023

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions Bot added the Stale label Nov 9, 2023
@github-actions
Copy link
Copy Markdown
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions Bot closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants