Some comments for better understanding#199
Closed
akash19jain wants to merge 1 commit intoTheAlgorithms:masterfrom
akash19jain:patch-1
Closed
Some comments for better understanding#199akash19jain wants to merge 1 commit intoTheAlgorithms:masterfrom akash19jain:patch-1
akash19jain wants to merge 1 commit intoTheAlgorithms:masterfrom
akash19jain:patch-1
Conversation
christianbender
requested changes
Feb 13, 2019
Collaborator
christianbender
left a comment
christianbender
left a comment
There was a problem hiding this comment.
Good Work! I have some suggestions
| } | ||
|
|
||
| int isBalanced(char *s) { | ||
| int isBalanced(char *s) //function which returns if the entered expression is balanced or not |
Collaborator
There was a problem hiding this comment.
Can you use multi-line comments such as:
/*
DESCRIPTION
*/
int isBalanced(char *s)Thanks
|
|
||
| x=pop(); | ||
| if( x=='{'&&s[i]!='}') | ||
| if( x=='{'&&s[i]!='}') //to check if the opening bracket of the same type at the closing one is popped. |
Collaborator
There was a problem hiding this comment.
Can you put in spaces between the operators and conditions, such as
x == '{' && s[i] != '}'for more readability
christianbender
added
on hold
Practice coding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.