Correct and improve prime test #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no prime numbers smaller than 2, but 2 itself is prime.
Spikatrix
reviewed
Oct 6, 2019
Spikatrix
left a comment
Spikatrix
left a comment
There was a problem hiding this comment.
Looks good. Although, it would be better if you move the sqrt to another variable so that it won't get evaluated in every iteration of the loop. Also, some spaces around the modulus operator would be nice: if (x % i == 0)
added spaces around the %-operator and assigned sqrt(x) to a variable
Contributor
Author
Implemented your suggestions |
ashwek
requested changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no prime numbers smaller than 2, but 2 itself is prime.