added solution & modified README.md for problem 121 #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The for loop utilized in 283 was improperly structured as 'start' was no declared as the value to index. Also, make the other cases more readable. Signed-off-by: RJ Trujillo <certifiedblyndguy@gmail.com>
Added commented solution to problem 461
leetcode: Address readability of a few cases, and fix 283
…sert-position Feature/search insert position
Added commented solution to Leetcode problem 476
danghai
reviewed
Oct 6, 2019
leetcode/src/121.c
Outdated
| int min_element = prices[0]; | ||
| int max_difference = prices[1] - min_element; | ||
| for(int i = 0; i < pricesSize; i++) { | ||
| /* whenever maximum profit can be made, we sell the stock. |
danghai
reviewed
Oct 6, 2019
leetcode/src/121.c
Outdated
| return 0; | ||
| } | ||
| int min_element = prices[0]; | ||
| int max_difference = prices[1] - min_element; |
Contributor
There was a problem hiding this comment.
You should initialize max_difference = 0 so that you do not need to check returning value. I mean:
int max_difference = 0. And then replace: return (max_difference < 0)? 0 : max_difference; by
return max_difference.
Contributor
|
Hi @hrishikeshSuresh . Could you add my 2nd way to resolve this problem? My way uses int maxcmp(int a, int b) {
return a >= b ? a : b;
}
/* max subarray problem by using Kadane's Algorithm */
int maxProfit(int* prices, int pricesSize){
/* maxCur: current maximum
maxSoFar: found maximum for subarray so far*/
int maxCur = 0, maxSoFar = 0;
for(int i = 1; i < pricesSize; i++) {
maxCur = maxcmp(0, maxCur + prices[i] - prices[i - 1]);
maxSoFar = maxcmp(maxSoFar, maxCur);
}
return maxSoFar;
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#249