Skip to content

GitHub Action run cpplint only on files that differ from master#500

Closed
cclauss wants to merge 4 commits intomasterfrom
cpplint_modified_files
Closed

GitHub Action run cpplint only on files that differ from master#500
cclauss wants to merge 4 commits intomasterfrom
cpplint_modified_files

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Nov 28, 2019

GitHub Action that runs cpplint only on those files in a pull request that have been modified vs. origin/master
This allows for gradual compliance with cpplint as only files added or modified are checked.
Other optional filepath verifications are commented out at the end of this file.

GitHub Action that runs cpplint only on those files in a pull request that have been modified vs. origin/master
This allows for gradual compliance with cpplint as only files added or modified are checked.
Other optional filepath verifications are commented out at the end of this file.
@kvedala
Copy link
Collaborator

kvedala commented May 28, 2020

Thank you @cclauss. The existing code does not conform to the CPPLINT standard and would break the system. I suggest we could use the clang-format program to automate the formatting once on all the existing code and the new ones instead of just throwing in an error.

@kvedala
Copy link
Collaborator

kvedala commented Jun 28, 2020

@cclauss wouldn't this PR be superseded by #543 ?

@cclauss cclauss closed this Jun 28, 2020
@cclauss cclauss deleted the cpplint_modified_files branch June 28, 2020 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants