-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Resolved PR #532 #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved PR #532 #538
Conversation
Code to implement Ascending Priority Queue
Program to demonstrate Merge sort algorithm without recursion
deadshotsb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes are requested
A Demo Sample Test case added
Added the output of the file
Added output of the program
shubhamsah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes mentioned have been done
|
Can you please also include documentation to the code. This repository is meant for educational purposes so that others can read your code and learn from it. |
|
Okay I will do It. Thanks for mentioning. Is there any changes in the code?? If you are satisfied with the code I ll move forward to Documentation. |
|
Filenames should be all small letters without spaces including the suffix Other than the above corrections, good work. |
|
All the said changes were done! Thank you. |
Implementation of Queue using Linked List.
deadshotsb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
Documentation was not to the standard as requested in the comments above. The documentation should be such that a lay person would be able to read and learn from your code. This is an educational repository. Hence, documentation should include at least the following:
|
No description provided.