Skip to content

Conversation

@shubhamsah
Copy link
Member

No description provided.

Program to demonstrate Merge sort algorithm without recursion
Copy link
Member

@deadshotsb deadshotsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes are requested

deadshotsb and others added 3 commits May 26, 2020 20:58
A Demo Sample Test case added
Added the output of the file
Added output of the program
Copy link
Member Author

@shubhamsah shubhamsah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the changes mentioned have been done

@kvedala
Copy link
Collaborator

kvedala commented May 26, 2020

Can you please also include documentation to the code. This repository is meant for educational purposes so that others can read your code and learn from it.
see for example, https://github.com/TheAlgorithms/C/blob/master/project_euler/Problem%2015/sol1.c

@shubhamsah
Copy link
Member Author

shubhamsah commented May 26, 2020

Okay I will do It. Thanks for mentioning. Is there any changes in the code?? If you are satisfied with the code I ll move forward to Documentation.

@kvedala
Copy link
Collaborator

kvedala commented May 26, 2020

Filenames should be all small letters without spaces including the suffix .c.

Other than the above corrections, good work.

@shubhamsah
Copy link
Member Author

All the said changes were done! Thank you.

Implementation of Queue using Linked List.
Copy link
Member

@deadshotsb deadshotsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@deadshotsb deadshotsb merged commit 1c07d61 into TheAlgorithms:master May 28, 2020
@kvedala
Copy link
Collaborator

kvedala commented May 28, 2020

Documentation was not to the standard as requested in the comments above. The documentation should be such that a lay person would be able to read and learn from your code. This is an educational repository. Hence, documentation should include at least the following:

  1. brief file description
  2. inline comments to understand the reasoning what the particular line statement does
  3. comments that describe the function, structure, etc.
    Please see this example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants