Skip to content

Data Structure: Queue#563

Closed
shubhamdp wants to merge 3 commits intoTheAlgorithms:masterfrom
shubhamdp:master
Closed

Data Structure: Queue#563
shubhamdp wants to merge 3 commits intoTheAlgorithms:masterfrom
shubhamdp:master

Conversation

@shubhamdp
Copy link
Copy Markdown
Contributor

@shubhamdp shubhamdp commented Jul 10, 2020

Queue DS with doxygen.

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Copy link
Copy Markdown
Collaborator

@kvedala kvedala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a work in progress. Please make the fixes requested and update the documentation. Thank you

Comment thread data_structures/queue/queue.c Outdated
Comment thread data_structures/queue/queue.c Outdated
Comment thread data_structures/queue/queue.c
Comment thread data_structures/queue/queue.c
@kvedala
Copy link
Copy Markdown
Collaborator

kvedala commented Jul 10, 2020

please move the file from the subfolder to data_structures

@shubhamdp
Copy link
Copy Markdown
Contributor Author

please move the file from the subfolder to data_structures

There is already a queue.c in data_structures

@kvedala
Copy link
Copy Markdown
Collaborator

kvedala commented Jul 13, 2020

please move the file from the subfolder to data_structures

There is already a queue.c in data_structures

Is there a difference between the existing file and your contribution? If there is, the new contributions should also be a single file but with a different name - maybe queues2.c
If there is, please update the Pull-Request description. The structure was provided for convenience to the authors to share exactly what is being contributed and the reviewers can understand what exactly to review and how best to help.
Ensure to follow the checklist as well. Thank you

Comment thread data_structures/queue/queue.c
@shubhamdp shubhamdp closed this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants