Skip to content

Optimized bubblesort.c#654

Closed
Hariprasad004 wants to merge 1 commit intoTheAlgorithms:masterfrom
Hariprasad004:master
Closed

Optimized bubblesort.c#654
Hariprasad004 wants to merge 1 commit intoTheAlgorithms:masterfrom
Hariprasad004:master

Conversation

@Hariprasad004
Copy link
Copy Markdown

@Hariprasad004 Hariprasad004 commented Oct 13, 2020 •
edited by gitpod-io Bot
Loading

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Removed unnecessary codes

@Panquesito7 Panquesito7 added the enhancement New feature or request label Oct 13, 2020
Panquesito7
Panquesito7 reviewed Oct 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Panquesito7 Panquesito7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good; though, all algorithms
should have a test function with assert checks.

Could you please, re-add the tests again?
Also, you removed the documentation. Please re-add it again.

@kvedala
Copy link
Copy Markdown
Collaborator

kvedala commented Oct 16, 2020

This looks like an invalid Pr, @Panquesito7
The updated code has no test function, documentation is removed, etc.

@Panquesito7 Panquesito7 added invalid and removed enhancement New feature or request labels Oct 16, 2020
@Panquesito7
Copy link
Copy Markdown
Member

Panquesito7 commented Oct 16, 2020

Right, I think we shall close it, then.
Sorry for my not noticing it. 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 left review comments

Assignees

No one assigned

Labels

invalid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hariprasad004 @kvedala @Panquesito7