Skip to content

The KnapsackProblem#655

Closed
mallick370 wants to merge 1 commit intoTheAlgorithms:masterfrom
mallick370:master
Closed

The KnapsackProblem#655
mallick370 wants to merge 1 commit intoTheAlgorithms:masterfrom
mallick370:master

Conversation

@mallick370
Copy link

@mallick370 mallick370 commented Oct 13, 2020

Hacktoberfest 2020 - Implement C algorithms or data structures, fix existing ones and more! #633

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Hacktoberfest 2020 - Implement C algorithms or data structures, fix existing ones and more! TheAlgorithms#633
@Panquesito7 Panquesito7 added Autochecks are failing Failing CI Auto-checks enhancement New feature or request Proper Documentation Required requested to write the documentation properly labels Oct 13, 2020
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is not up to the repository standards.
Please read them carefully and follow them.

Also see the typical structure of a program for good code and documentation. 🙂


#include <bits/stdc++.h>

using namespace std;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A C program cannot use the std namespace (it's only for C++).
The appropriate library should be the stdio.h, and using printf and scanf.

@@ -0,0 +1,62 @@

#include <bits/stdc++.h>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library is discouraged, consider using the necessary libraries separately.

return finalvalue;
}

int main()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
int main()
/**
* @brief Main function
* @returns 0 on exit
*/
int main()

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Nov 5, 2021
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@github-actions github-actions bot closed this Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Autochecks are failing Failing CI Auto-checks enhancement New feature or request Proper Documentation Required requested to write the documentation properly Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants