fix: several bugs on games/tic_tac_toe.c by kana800 · Pull Request #771 · TheAlgorithms/C

kana800 · 2020-11-04T16:32:23Z

Description of Change

Issue: #729
As mentioned in the issue , The piece code listed below throws the program into an loop (from line 247) if an invalid character is entered.

        else
        {
+            int n = check_placex();
-             printf("Invalid move\n");

-            printf("Enter new position : ");
-            scanf("%d", &n1);
+           placex(n);
-            placex(n1);
        }
    }
    else
    {
-        printf("Invalid move \n");
+       int n = check_placex();
-        printf("Enter new position : ");
-        scanf("%d", &n1);
+       placex(n);
-        placex(n1);
    }
}

Fixes / Changes

Added an array [dynamic] at `line36` :

+ int *stored_pos = NULL;

line 47:

+  stored_pos = (int*)calloc(9,sizeof(int))

Assignment of the stored_pos array:

line 331, line 308 & line 278

example:

+ stored_pos[e] = 1;

Freed the stored_pos memory

line 75

+ free(stored_pos);

Added a new function called `check_places` at `line237` to `line256`

int check_placex(){
	char input[50];
	int n1;
	while (1){
		fgets(input,49,stdin);
		if ( strlen(input) > 2 || strlen(input)  == 0){
			fprintf(stderr,"Invalid move, Enter number 1 - 9: ");
			continue;
		}
		if(sscanf(input,"%d",&n1) != 1){
			fprintf(stderr,"Invalid move, Enter number 1 - 9: ");
			continue;
		} 
		if ((stored_pos[n1-1] == 1) || (n1== 0)){
			fprintf(stderr,"Already allocated, Enter number: ");
			continue;
		}
		return n1;
	}
}

The while-loop in the above above function will ask for an input until it gets a correct output.

The first if condition checks whether the input is within the range. (strlen() is used so string.h lib is need)
Second if condition checks if the value is integer
Third if condition checks if the value (posistion) is already occupied.

References

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:

Panquesito7

LGTM. Thank you for your contribution! 🎉 👍

kvedala

a simple fix for the bug would be to simply ensure that the input number is >=0 & <=9. There is no need to make so many changes.

kvedala · 2020-11-25T09:22:13Z

+ * stored_pos array will store posistion of that were already allocated by the user
+ * calloc(9,sizeof(int)) means an array of 9 elements.
+ */
+int *stored_pos = NULL;


Suggested change

int *stored_pos = NULL;

static unsigned char *stored_pos = NULL;

static to recognize the variable as local to this file.

unsigned char pointer to be same as line 30
Is this even required? isnt it serving the same purpose as game_table?

I can't actually remember what I have done here, but I think the purpose of stored_pos was to make sure that the values that was inserted by the user was not overwritten.

kana800 · 2020-11-25T09:37:02Z

a simple fix for the bug would be to simply ensure that the input number is >=0 & <=9. There is no need to make so many changes.

I went a bit overboard with it

kana800 · 2020-11-26T10:20:49Z

@Panquesito7 any idea why the autochecks are failing ?
I read the logs and I don't get it

kvedala · 2020-11-26T11:27:52Z

a simple fix for the bug would be to simply ensure that the input number is >=0 & <=9. There is no need to make so many changes.

I went a bit overboard with it

Good, it would be better to add your new contribution as a "v2" of the program, a new file as described in the contribution guidelines while keeping the fix to this code to its minimal.

kana800 · 2020-12-06T08:04:27Z

a simple fix for the bug would be to simply ensure that the input number is >=0 & <=9. There is no need to make so many changes.

I went a bit overboard with it

Good, it would be better to add your new contribution as a "v2" of the program, a new file as described in the contribution guidelines while keeping the fix to this code to its minimal.

Kept everything to minimal, removed stored_pos and used game_table . Instead of using scanf i went with another approach (line : 230), scanf will take the \n of the input buffer.

Panquesito7

Please fix clang-tidy warnings.

Panquesito7 · 2020-12-14T18:37:03Z

+/**
+ * @brief Helper function of place_x,place_y function
+ *
+ * @param None


No need to add this if there are no parameters.

kana800 · 2020-12-19T10:07:38Z

@Panquesito7 please check the windows log

Panquesito7

Please see https://github.com/TheAlgorithms/C/runs/1581156179#step:4:1407.

kana800 · 2020-12-20T04:03:02Z

Please see https://github.com/TheAlgorithms/C/runs/1581156179#step:4:1407.

Thanks a lot ! 🙏🏽

Panquesito7 · 2020-12-20T04:54:01Z

https://github.com/TheAlgorithms/C/runs/1583568825#step:4:1424

kana800 · 2020-12-22T16:13:51Z

2020-12-22T16:06:10.6979145Z   tic_tac_toe.c
2020-12-22T16:06:10.7562749Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stdio.h(378,9): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]
2020-12-22T16:06:10.7689739Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stdio.h(2437,9): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]
2020-12-22T16:06:10.7722359Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_search.h(188,5): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]
2020-12-22T16:06:10.7778834Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stdlib.h(79,5): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]
2020-12-22T16:06:10.7856859Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\stdlib.h(1286,5): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]
2020-12-22T16:06:10.7904488Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\time.h(589,5): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]
2020-12-22T16:06:10.7935445Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_memory.h(76,5): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]
2020-12-22T16:06:10.7984994Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\corecrt_wstring.h(573,5): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]
2020-12-22T16:06:10.8038939Z C:\Program Files (x86)\Windows Kits\10\Include\10.0.17763.0\ucrt\string.h(531,5): warning C5105: macro expansion producing 'defined' has undefined behavior [D:\a\C\C\build\games\tic_tac_toe.vcxproj]

@Panquesito7
Fixed Errors from my end, anything wrong with windows version of LGTM analysis?

Panquesito7 · 2020-12-23T00:09:13Z

anything wrong with windows version of LGTM analysis?

LGTM seems to be working fine (no errors/bugs reported).
~~Though I still see some Windows warnings reported by the CI.~~

Panquesito7 · 2020-12-23T00:34:41Z

My bad! It seems it has something to do with latest commit in the repository (b2def5c).
Your code seems to be good, though. I do not see any errors reported. Only warnings, though.

kvedala · 2021-02-05T09:27:11Z

My bad! It seems it has something to do with latest commit in the repository (b2def5c).
Your code seems to be good, though. I do not see any errors reported. Only warnings, though.

The CI fix is present here: #796
Once this is merged,
The pull-requests and/or commits since Nov 29, 2020 can be rechecked by force triggering the CI checks on them, including this one

kana800 · 2021-02-08T05:40:02Z

Recheck done 👍🏽 , Everything seems to be working alright

north8side · 2021-02-09T07:36:54Z

+{   
+    srand( (unsigned int)time(NULL));
    int l = 0;
    do


north8side · 2021-02-09T07:38:17Z

 int main()
-{   srand(time(NULL));
+{   
+    srand( (unsigned int)time(NULL));


north8side · 2021-02-09T07:39:06Z

+			fprintf(stderr,"Invalid move, Enter number 1 - 9: ");
+			continue;
+		}
+		if(sscanf(input,"%d",&n1) != 1){


kana800 added 2 commits November 4, 2020 21:52

fixed several bugs on tic_tac_toe

2d27be8

final changes bug fixed

5ba242f

kana800 marked this pull request as ready for review November 4, 2020 18:15

Panquesito7 linked an issue Nov 4, 2020 that may be closed by this pull request

[BUG] Unhandled Exception in Tic-tack-toe-game #729

Closed

Panquesito7 added the bugfix Correction to existing algorithms label Nov 4, 2020

Panquesito7 changed the title ~~fixed several bugs on tic_tac_toe~~ fix: several bugs on games/tic_tac_toe.c Nov 4, 2020

Panquesito7 approved these changes Nov 4, 2020

View reviewed changes

Panquesito7 added the approved Approved; waiting for merge label Nov 4, 2020

Panquesito7 requested a review from kvedala November 4, 2020 20:06

kvedala requested changes Nov 25, 2020

View reviewed changes

added requested changes

d78506e

Panquesito7 added the Autochecks are failing Failing CI Auto-checks label Nov 25, 2020

fixed changes

8299b01

fixed stuff

67c8883

Panquesito7 requested changes Dec 14, 2020

View reviewed changes

kana800 added 2 commits December 19, 2020 15:24

fix clang-tidy warnings

3ec1d85

removed unnecessary headers

535c531

Panquesito7 requested changes Dec 20, 2020

View reviewed changes

Comment thread games/tic_tac_toe.c

Comment thread games/tic_tac_toe.c

resolved some warnings

de070f6

fixed warning c4244

e024589

Panquesito7 removed the approved Approved; waiting for merge label Dec 23, 2020

Panquesito7 added Changes requested enhancement New feature or request labels Dec 23, 2020

Tiggering CI checks

31220af

Panquesito7 removed the Autochecks are failing Failing CI Auto-checks label Feb 8, 2021

Panquesito7 requested a review from kvedala February 8, 2021 16:55

north8side reviewed Feb 9, 2021

View reviewed changes

kvedala merged commit c4e80b8 into TheAlgorithms:master Feb 10, 2021

	int *stored_pos = NULL;
	static unsigned char *stored_pos = NULL;

Uh oh!

Conversation

kana800 commented Nov 4, 2020 • edited by gitpod-io bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Fixes / Changes

Added an array [dynamic] at line36 :

Assignment of the stored_pos array:

Freed the stored_pos memory

Added a new function called check_places at line237 to line256

References

Checklist

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

kvedala left a comment

Choose a reason for hiding this comment

Uh oh!

kvedala Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

kana800 Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

kana800 commented Nov 25, 2020

Uh oh!

kana800 commented Nov 26, 2020

Uh oh!

kvedala commented Nov 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kana800 commented Dec 6, 2020

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Panquesito7 Dec 14, 2020

Choose a reason for hiding this comment

Uh oh!

kana800 Dec 15, 2020

Choose a reason for hiding this comment

Uh oh!

kana800 commented Dec 19, 2020

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kana800 commented Dec 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Panquesito7 commented Dec 20, 2020

Uh oh!

kana800 commented Dec 22, 2020

Uh oh!

Panquesito7 commented Dec 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Panquesito7 commented Dec 23, 2020

Uh oh!

kvedala commented Feb 5, 2021

Uh oh!

kana800 commented Feb 8, 2021

Uh oh!

north8side Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

north8side Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

north8side Feb 9, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

kana800 commented Nov 4, 2020 •

edited by gitpod-io bot

Loading

Added an array [dynamic] at `line36` :

Added a new function called `check_places` at `line237` to `line256`

kvedala commented Nov 26, 2020 •

edited

Loading

kana800 commented Dec 20, 2020 •

edited

Loading

Panquesito7 commented Dec 23, 2020 •

edited

Loading