feat: TCP Client Server Half Duplex Communication by NVombat · Pull Request #853 · TheAlgorithms/C

NVombat · 2021-08-27T05:17:49Z

Description of Change

Added the server and client code for half duplex TCP communication. Ran the code to make sure it compiles and runs successfully. Commented the code and followed contributing guidelines.

References

Implements Half Duplex Communication for #852

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes:

ayaankhan98

please revert .vscode/settings.json

NVombat · 2021-08-27T10:24:10Z

I had deleted the folder by mistake. I restored the deletion and then pushed the file back into the repository. Will That be fine?

Panquesito7

Also fix these warnings, please.

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7

Please enable GitHub Actions in your repository of this fork in this link: https://github.com/NVombat/C/actions

Co-authored-by: David Leal <halfpacho@gmail.com>

NVombat · 2021-08-31T15:44:12Z

Are there any other changes that need to be made ?

Co-authored-by: David Leal <halfpacho@gmail.com>

NVombat · 2021-08-31T17:01:10Z

I updated all comment formatting to be uniform.

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7

Amazing work, @NVombat! It's been great to be your first contribution here! We hope you keep contributing! 😄👍🎉

NVombat · 2021-09-01T19:32:40Z

Thank you! Will contribute more for sure!

Panquesito7 · 2021-09-07T01:43:41Z

@Amino19, would you like to review this PR? Thanks. 🙂

@ayaankhan98 and @mishraabhinn, please wait until @Amino19 reviews this PR.
They're practicing with us and learning to review PRs with us. 🙂

ayaankhan98

LGTM!

aminoxix

@NVombat: Thanks for your contributions in The Algorithms!
LGTM! 🥳

@Panquesito7: Pl take this to your end! : )

TCP Client Server Half Duplex Comm

f83eb56

ayaankhan98 requested changes Aug 27, 2021

View reviewed changes

reverting .vscode/settings.json in reference to request

dd1e30e

Set gitignore back to original state

9e7c3ad

ayaankhan98 reviewed Aug 27, 2021

View reviewed changes

Comment thread .vscode/settings.json Outdated

Panquesito7 changed the title ~~TCP Client Server Half Duplex Communication~~ feat: TCP Client Server Half Duplex Communication Aug 27, 2021

Panquesito7 requested changes Aug 27, 2021

View reviewed changes

Panquesito7 added Autochecks are failing Failing CI Auto-checks Changes requested enhancement New feature or request Proper Documentation Required requested to write the documentation properly labels Aug 27, 2021

Panquesito7 requested changes Aug 27, 2021

View reviewed changes

NVombat and others added 5 commits August 27, 2021 21:03

Update .vscode/settings.json

f1a634c

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_client.c

d724e27

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

a549c1c

Co-authored-by: David Leal <halfpacho@gmail.com>

Making all the requested changes

9c90d04

Making Requested Changes

9dd80a8

Panquesito7 requested changes Aug 27, 2021

View reviewed changes

NVombat and others added 6 commits August 28, 2021 00:13

Update client_server/tcp_half_duplex_client.c

926d8e1

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_client.c

3a07cdf

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_client.c

e998682

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

b391548

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

c4204d7

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

776e76e

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 removed the Autochecks are failing Failing CI Auto-checks label Aug 27, 2021

Panquesito7 requested changes Aug 27, 2021

View reviewed changes

Comment thread client_server/tcp_half_duplex_client.c Outdated

Comment thread client_server/tcp_half_duplex_client.c Outdated

Comment thread client_server/tcp_half_duplex_server.c Outdated

NVombat and others added 3 commits August 28, 2021 02:26

Made Requested Changes - Added Documentation & Comments

58b36a9

Update client_server/tcp_half_duplex_client.c

9f7727b

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

3d44c4a

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 reviewed Aug 30, 2021

View reviewed changes

Comment thread client_server/tcp_half_duplex_client.c Outdated

Comment thread client_server/tcp_half_duplex_server.c Outdated

NVombat and others added 3 commits August 30, 2021 23:30

Updated Documentation Format - Comments made in correct format

a70db25

Update client_server/tcp_half_duplex_client.c

5bf4166

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

2f40c35

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 reviewed Aug 31, 2021

View reviewed changes

Comment thread client_server/tcp_half_duplex_client.c Outdated

Comment thread client_server/tcp_half_duplex_server.c

Update client_server/tcp_half_duplex_client.c

ce36252

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 reviewed Aug 31, 2021

View reviewed changes

Comment thread client_server/tcp_half_duplex_client.c Outdated

Comment thread client_server/tcp_half_duplex_server.c Outdated

NVombat and others added 3 commits August 31, 2021 22:25

Update client_server/tcp_half_duplex_client.c

bc8fe12

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

cddbac6

Co-authored-by: David Leal <halfpacho@gmail.com>

Comment formatting updated

02b33f6

Panquesito7 reviewed Sep 1, 2021

View reviewed changes

Comment thread client_server/tcp_half_duplex_client.c

Comment thread client_server/tcp_half_duplex_server.c

Comment thread client_server/tcp_half_duplex_server.c

NVombat and others added 3 commits September 1, 2021 11:09

Update client_server/tcp_half_duplex_client.c

86a1594

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

9a36633

Co-authored-by: David Leal <halfpacho@gmail.com>

Update client_server/tcp_half_duplex_server.c

ecc495c

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 requested changes Sep 1, 2021

View reviewed changes

Comment thread client_server/tcp_half_duplex_client.c Outdated

Comment thread client_server/tcp_half_duplex_server.c Outdated

Updated Data Type - uint32_t for socket descriptors

e354917

Panquesito7 approved these changes Sep 1, 2021

View reviewed changes

Panquesito7 requested review from ayaankhan98 and mishraabhinn September 1, 2021 19:26

Panquesito7 added approved Approved; waiting for merge and removed Changes requested Proper Documentation Required requested to write the documentation properly labels Sep 1, 2021

Panquesito7 requested a review from aminoxix September 7, 2021 01:43

ayaankhan98 approved these changes Sep 7, 2021

View reviewed changes

aminoxix approved these changes Sep 7, 2021

View reviewed changes

ayaankhan98 merged commit 0bcf737 into TheAlgorithms:master Sep 7, 2021

Uh oh!

Conversation

NVombat commented Aug 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

References

Checklist

Uh oh!

ayaankhan98 left a comment

Choose a reason for hiding this comment

Uh oh!

NVombat commented Aug 27, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NVombat commented Aug 31, 2021

Uh oh!

Uh oh!

Uh oh!

NVombat commented Aug 31, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

NVombat commented Sep 1, 2021

Uh oh!

Panquesito7 commented Sep 7, 2021

Uh oh!

ayaankhan98 left a comment

Choose a reason for hiding this comment

Uh oh!

aminoxix left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

NVombat commented Aug 27, 2021 •

edited

Loading