Skip to content

feat: TCP Full Duplex Server Client Communication#856

Merged
Panquesito7 merged 6 commits intoTheAlgorithms:masterfrom
NVombat:master
Sep 22, 2021
Merged

feat: TCP Full Duplex Server Client Communication#856
Panquesito7 merged 6 commits intoTheAlgorithms:masterfrom
NVombat:master

Conversation

@NVombat
Copy link
Copy Markdown
Contributor

@NVombat NVombat commented Sep 15, 2021

Description of Change

Implemented a Full Duplex Communication server client model using a TCP socket

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 15, 2021
Copy link
Copy Markdown
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 😄👍
Please enable GitHub Actions in your repository of this fork in this link: https://github.com/NVombat/C/actions

Comment thread client_server/tcp_full_duplex_server.c Outdated
Comment thread client_server/tcp_full_duplex_client.c Outdated
Copy link
Copy Markdown
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

Comment thread client_server/tcp_full_duplex_client.c
Comment thread client_server/tcp_full_duplex_client.c
Comment thread client_server/tcp_full_duplex_server.c
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Copy Markdown
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Awesome work, @NVombat! We're glad you are enjoying contributing with us! Thanks for your contribution! 🥳🎉

@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Sep 20, 2021
@Panquesito7
Copy link
Copy Markdown
Member

Thanks for reviewing, @Amino19! 😄

@Panquesito7 Panquesito7 merged commit 690d490 into TheAlgorithms:master Sep 22, 2021
@Panquesito7 Panquesito7 changed the title TCP Full Duplex Server Client Communication feat: TCP Full Duplex Server Client Communication Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved; waiting for merge enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants