feat: add infix to postfix converter algorithm by kumaryash18 · Pull Request #869 · TheAlgorithms/C

kumaryash18 · 2021-10-06T14:15:22Z

Description of Change

Added a program to convert an infix expression to postfix expression in misc

References

Checklist

Added description of change
Added file name matches File name guidelines
PR title follows semantic commit guidelines
I acknowledge that all my contributions will be made under the project's license.

Notes:

A program in C to convert an infix expression to postfix expression

Panquesito7

Hey there! Thank you for submitting a PR! 😄Looks like this algorithm is already implemented here 👀 Please name your file infix_to_postfix2.c and move it to the conversions directory.
Also, this does not meet our requirements. Check out our repository standards. Please read them carefully and follow them. Let us know if you need any help here or in our Discord server. 🙂

Panquesito7

Please enable GitHub Actions in your repository of this fork in this link: https://github.com/kumaryash18/C/actions
Also, please fix clang-tidy warnings.

Panquesito7 · 2021-10-07T16:02:33Z

conversions/infix_to_postfix2.c

+#include<stdio.h>	// for printf() and scanf()
+#include<string.h>	// for strlen()
+#include<ctype.h>	// for isalnum()
+#include<process.h>	// for exit()


Suggested change

#include<stdio.h> // for printf() and scanf()

#include<string.h> // for strlen()

#include<ctype.h> // for isalnum()

#include<process.h> // for exit()

#include<stdio.h> /// for IO operations

#include<string.h> /// for strlen()

#include<ctype.h> /// for isalnum()

#include<process.h> /// for exit()

Panquesito7

Almost there! 😄

Panquesito7 · 2021-10-07T18:21:25Z

conversions/infix_to_postfix2.c

+	char stack[10];	//< array stack
+	int top;		//< stores index of top element
+};
+struct Stack st;	// global declaration of stack st


Suggested change

char stack[10]; //< array stack

int top; //< stores index of top element

};

struct Stack st; // global declaration of stack st

char stack[10]; ///< array stack

int top; ///< stores index of top element

};

struct Stack st; ///< global declaration of stack st

Panquesito7 · 2021-10-07T18:22:34Z

conversions/infix_to_postfix2.c

+	if(opd == '+' || opd == '-')
+		return 0;
+	else if(opd == '/' || opd == '*' || opd == '%')
+		return 1;
+	else
+		return -1;


Suggested change

if(opd == '+' || opd == '-')

return 0;

else if(opd == '/' || opd == '*' || opd == '%')

return 1;

else

return -1;

if(opd == '+' || opd == '-') {

return 0;

}

else if(opd == '/' || opd == '*' || opd == '%') {

return 1;

}

else {

return -1;

}

Panquesito7 · 2021-10-07T18:24:29Z

conversions/infix_to_postfix2.c

+	if(st.top == -1)
+		return 1;


Suggested change

if(st.top == -1)

return 1;

if(st.top == -1) {

return 1;

}

Panquesito7 · 2021-10-07T18:25:15Z

conversions/infix_to_postfix2.c

+ * @returns popped character
+ */
+char pop() {
+	char item;


Please add a one-line description of what the variable is for (see the example below). Same in other parts of the code.

int data = 0; ///< The value/key of the node.

…pression

Panquesito7

Please fix the continuous integration. Let us know if you need any help here or in our Discord server. 😃

Panquesito7

Almost there! 😄

conversions/infix_to_postfix2.c

Panquesito7 · 2021-10-12T16:26:15Z

conversions/infix_to_postfix2.c

+ * @returns `true` if stack is empty
+ * @returns `false` if stack is not empty
+ */
+int isEmpty() {


Consider using uint64_t for non-negative values (or their appropriate size: uint32_t, uint16_t, uint8_t) or int64_t for negative values. Check other parts of the code (reference). Let us know if you need any help here or in our Discord server. 😃

Panquesito7 · 2021-10-12T16:26:29Z

conversions/infix_to_postfix2.c

+
+/**
+ * @brief Function to check priority of operators
+ * @param opd- operator whose priority is to be checked


Suggested change

* @param opd- operator whose priority is to be checked

* @param opd operator whose priority is to be checked

Panquesito7 · 2021-10-12T16:28:52Z

conversions/infix_to_postfix2.c

+		return -1;
+	}
+}
+


Please add self-test cases so we can verify that your program works as excepted (see the typical structure of a program as a reference). Let us know if you need any help here or in our Discord server. 😃

Panquesito7

Almost there! 😄

Panquesito7 · 2021-10-13T16:21:12Z

conversions/infix_to_postfix2.c

+/**
+ * @file
+ * @brief infix to postfix converter
+ * Wikipedia- [Shunting-yard algorithm](https://en.wikipedia.org/wiki/Shunting-yard_algorithm)


Is this the Shunting Yard algorithm or Infix to Postfix algorithm? 🤔

Not sure if Wikipedia names it that way, for clarity provided a different reference. Hope it seems good :)

Panquesito7 · 2021-10-13T16:21:27Z

conversions/infix_to_postfix2.c

+	char stack[10];		///< array stack
+	int top;			///< stores index of top element


Suggested change

char stack[10]; ///< array stack

int top; ///< stores index of top element

char stack[10]; ///< array stack

int top; ///< stores index of top element

Panquesito7 · 2021-10-13T16:29:54Z

conversions/infix_to_postfix2.c

+	char item;				///< to store popped value to be returned
+	if(st.top == -1) {		// underflow condition
+		printf("Stack underflow...");
+		exit(0);


If this is an error statement we should use 1 instead.

Suggested change

exit(0);

exit(1);

Panquesito7 · 2021-10-13T16:35:20Z

conversions/infix_to_postfix2.c

+ * @returns `true` if stack is empty
+ * @returns `false` if stack is not empty


This would be for a bool function, and this is an integer function. Please update it as needed.

Panquesito7 · 2021-10-13T16:36:09Z

conversions/infix_to_postfix2.c

+	st.top = -1;						// initialize
+	test();								// run self-test implementations


Suggested change

st.top = -1; // initialize

test(); // run self-test implementations

st.top = -1; /// initialize

test(); /// run self-test implementations

Panquesito7 · 2021-10-13T16:36:11Z

conversions/infix_to_postfix2.c

+	printf("Postfix: %s", convert(inf));
+	return 0;
+}
+


Suggested change

Panquesito7 · 2021-10-13T18:37:41Z

conversions/infix_to_postfix2.c

+/**
+ * @file
+ * @brief infix to postfix converter
+ * Reference- [infix to postfix converter](https://www.includehelp.com/c/infix-to-postfix-conversion-using-stack-with-c-program.aspx)


Suggested change

* Reference- [infix to postfix converter](https://www.includehelp.com/c/infix-to-postfix-conversion-using-stack-with-c-program.aspx)

Panquesito7 · 2021-10-13T18:38:08Z

conversions/infix_to_postfix2.c

@@ -0,0 +1,160 @@
+/**
+ * @file
+ * @brief infix to postfix converter


Suggested change

* @brief infix to postfix converter

* @brief [Infix to Postfix converter](https://www.includehelp.com/c/infix-to-postfix-conversion-using-stack-with-c-program.aspx) implementation

Panquesito7 · 2021-10-13T18:39:37Z

conversions/infix_to_postfix2.c

+
+/**
+ * @brief Function to check whether stack is empty or not
+ * @returns 1 if stack is empty


Suggested change

* @returns 1 if stack is empty

* @returns 1 if the stack IS empty

Panquesito7 · 2021-10-13T18:39:45Z

conversions/infix_to_postfix2.c

+/**
+ * @brief Function to check whether stack is empty or not
+ * @returns 1 if stack is empty
+ * @returns 0 if stack is not empty


Suggested change

* @returns 0 if stack is not empty

* @returns 0 if the stack is NOT empty

Panquesito7 · 2021-10-13T18:40:22Z

conversions/infix_to_postfix2.c

+int main() {
+	st.top = -1;			/// initialize
+	test();				/// run self-test implementations
+	char inf[25];						///< to store input infix expression


Suggested change

char inf[25]; ///< to store input infix expression

char inf[25]; ///< to store input infix expression

Panquesito7 · 2021-10-14T18:48:29Z

conversions/infix_to_postfix2.c

+	   input- "(A/(B-C)*D+E)"
+	   expected output- "ABC-/D*E+"
+	 */
+	assert(strcmp(convert("(A/(B-C)*D+E)"), "ABC-/D*E+") == 0); 			// this ensures that the algorithm works as expected


Suggested change

assert(strcmp(convert("(A/(B-C)*D+E)"), "ABC-/D*E+") == 0); // this ensures that the algorithm works as expected

assert(strcmp(convert("(A/(B-C)*D+E)"), "ABC-/D*E+") == 0); /// this ensures that the algorithm works as expected

std::cout << "All tests have successfully passed!\n";

Panquesito7 · 2021-10-14T18:48:38Z

conversions/infix_to_postfix2.c

+	   input- "(A/(B-C)*D+E)"
+	   expected output- "ABC-/D*E+"
+	 */
+	assert(strcmp(convert("(A/(B-C)*D+E)"), "ABC-/D*E+") == 0); 			// this ensures that the algorithm works as expected


Feel free to add more tests as well (if applicable)! 🙂

Panquesito7

Impressive and awesome work! You've done amazing work, and it's been your
first contribution here! We hope you keep contributing! 😄👍🎉

After this PR is merged, you can ask for the
contributor role in our Discord server! 🚀

add infix to postfix converter algorithm

c02dba0

Panquesito7 requested changes Oct 6, 2021

View reviewed changes

Panquesito7 added Autochecks are failing Failing CI Auto-checks Changes requested enhancement New feature or request Proper Documentation Required requested to write the documentation properly labels Oct 6, 2021

docs: documentation changes

1d0d712

Panquesito7 requested changes Oct 7, 2021

View reviewed changes

kumaryash18 and others added 2 commits October 7, 2021 22:02

docs: documentation changes

32dd3e8

updating DIRECTORY.md

8566c2e

Panquesito7 requested changes Oct 7, 2021

View reviewed changes

kumaryash18 added 2 commits October 8, 2021 13:35

docs: documentation changes

45d92c5

Merge branch 'expression' of https://github.com/kumaryash18/C into ex…

da1dccf

…pression

kumaryash18 requested a review from Panquesito7 October 10, 2021 15:50

Panquesito7 requested changes Oct 10, 2021

View reviewed changes

fix: continuous integration

b0fa886

kumaryash18 requested a review from Panquesito7 October 11, 2021 09:16

Panquesito7 changed the title ~~add infix to postfix converter algorithm~~ feat: add infix to postfix converter algorithm Oct 12, 2021

Panquesito7 removed the Autochecks are failing Failing CI Auto-checks label Oct 12, 2021

Panquesito7 requested changes Oct 12, 2021

View reviewed changes

kumaryash18 added 3 commits October 13, 2021 16:13

[test, docs]: add test case, documentation changes

71a7353

docs: documentation changes

6e4f228

fix: continuous integration

9fae7a0

kumaryash18 requested a review from Panquesito7 October 13, 2021 11:25

Panquesito7 requested changes Oct 13, 2021

View reviewed changes

docs: documentation changes

dfa5034

kumaryash18 requested review from Panquesito7 October 13, 2021 17:15

Panquesito7 reviewed Oct 13, 2021

View reviewed changes

docs: documentation changes

b34b396

Panquesito7 reviewed Oct 14, 2021

View reviewed changes

test: add new test

f993e0f

Panquesito7 approved these changes Oct 16, 2021

View reviewed changes

Panquesito7 added approved Approved; waiting for merge and removed Changes requested Proper Documentation Required requested to write the documentation properly labels Oct 16, 2021

Panquesito7 requested review from aminoxix, ayaankhan98 and mishraabhinn October 16, 2021 01:44

aminoxix approved these changes Oct 16, 2021

View reviewed changes

Panquesito7 merged commit 654105c into TheAlgorithms:master Oct 17, 2021

	* @param opd- operator whose priority is to be checked
	* @param opd operator whose priority is to be checked

		char stack[10]; ///< array stack
		int top; ///< stores index of top element

		* @returns `true` if stack is empty
		* @returns `false` if stack is not empty

		st.top = -1; // initialize
		test(); // run self-test implementations

	* @brief infix to postfix converter
	* @brief [Infix to Postfix converter](https://www.includehelp.com/c/infix-to-postfix-conversion-using-stack-with-c-program.aspx) implementation

	* @returns 1 if stack is empty
	* @returns 1 if the stack IS empty

	* @returns 0 if stack is not empty
	* @returns 0 if the stack is NOT empty

	char inf[25]; ///< to store input infix expression
	char inf[25]; ///< to store input infix expression

	assert(strcmp(convert("(A/(B-C)D+E)"), "ABC-/DE+") == 0); // this ensures that the algorithm works as expected
	assert(strcmp(convert("(A/(B-C)D+E)"), "ABC-/DE+") == 0); /// this ensures that the algorithm works as expected
	std::cout << "All tests have successfully passed!\n";

Uh oh!

Conversation

kumaryash18 commented Oct 6, 2021 • edited by gitpod-io bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

References

Checklist

Uh oh!

Panquesito7 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

kumaryash18 commented Oct 6, 2021 •

edited by gitpod-io bot

Loading

Panquesito7 left a comment •

edited

Loading