Matrix determinant #881
Closed
Matrix determinant #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panquesito7
requested changes
Oct 13, 2021
Member
Panquesito7
left a comment
Panquesito7
left a comment
There was a problem hiding this comment.
Hey there! Thanks for submitting a PR! 😄 Please fix clang-tidy warnings.
Let us know if you need any help here or in our Discord server. 🙂
Panquesito7
added
Autochecks are failing
Panquesito7
requested changes
Oct 14, 2021
Member
Panquesito7
left a comment
Panquesito7
left a comment
There was a problem hiding this comment.
Great work! 😄 👍
Please make separate PRs for each algorithm: one for the factiorial_n.c file, one for the matrix_3.c file, etc.
| /* Testing function output*/ | ||
| assert(factorial(0) == 1); | ||
| assert(factorial(1) == 1); | ||
| assert(factorial(5) == 120); |
Member
There was a problem hiding this comment.
Suggested change
| assert(factorial(5) == 120); | |
| assert(factorial(5) == 120); | |
| std::cout << "All tests have successfully passed!\n"; |
Author
There was a problem hiding this comment.
Line 40, std::cout is from iostream header, i'll change to printf function from stdio.h definition.
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
* added Conversion/decimal_to_anybase.c
* Added Converstions/decimal_to_any_base.c
* Enhencement of decimal_to_any_base.c
* Update conversions/decimal_to_any_base.c
Co-authored-by: David Leal <halfpacho@gmail.com>
* Update conversions/decimal_to_any_base.c
Co-authored-by: David Leal <halfpacho@gmail.com>
* updating DIRECTORY.md
* Update conversions/decimal_to_any_base.c
Co-authored-by: David Leal <halfpacho@gmail.com>
* Update conversions/decimal_to_any_base.c
Co-authored-by: David Leal <halfpacho@gmail.com>
* text enhencement and debugging
* comments norming
* builtin int types declacration changed into arch optimized int types
* comments norming
* Adding booleans and int types normalization
* Translation of the program into a function and tests added
* Commentary rewriting in decimal_to_anybase and code beautify
* added 1 comments in main and code beautify
* Commentary norming
* Code norming
* Apply suggestions from code review
Co-authored-by: Votre Nom <Vous@exemple.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Cramer's Algorithm for a 3x3 Matrix