Skip to content

Optimized the Bubble Sort Algorithm#964

Closed
07abhi9av wants to merge 2 commits intoTheAlgorithms:masterfrom
07abhi9av:master
Closed

Optimized the Bubble Sort Algorithm#964
07abhi9av wants to merge 2 commits intoTheAlgorithms:masterfrom
07abhi9av:master

Conversation

@07abhi9av
Copy link
Copy Markdown

@07abhi9av 07abhi9av commented Sep 29, 2022

Description of Change

References

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

Copy link
Copy Markdown

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While efficiency and optimization, is important, having readable and understandable code is also very important. This includes using proper indentation and leaving the right amount of whitespace and newlines after expressions.

Comment thread sorting/bubble_sort.c Outdated
Comment thread sorting/bubble_sort.c Outdated
Comment thread sorting/bubble_sort.c Outdated
Comment thread sorting/bubble_sort.c Outdated
@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 30, 2022
@Panquesito7
Copy link
Copy Markdown
Member

Hey there! Thanks for your contribution 😄 The code is much shorter now, but is it not up to our standards. We use Doxygen-generated documentation for educational purposes so that other people can learn from the algorithms and implementations.

I'm sorry, but I'll have to be closing this PR.
We hope to see you contributing further. Thank you. 🙂

Don't hesitate to join our Discord community to talk about algorithms, hang with other people, and more.

@Panquesito7 Panquesito7 added invalid and removed enhancement New feature or request labels Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants