Optimized the Bubble Sort Algorithm#964
Closed
07abhi9av wants to merge 2 commits intoTheAlgorithms:masterfrom
07abhi9av:master
Closed
Optimized the Bubble Sort Algorithm#96407abhi9av wants to merge 2 commits intoTheAlgorithms:masterfrom 07abhi9av:master
07abhi9av wants to merge 2 commits intoTheAlgorithms:masterfrom
07abhi9av:master
Conversation
CaedenPH
suggested changes
Sep 29, 2022
CaedenPH
left a comment
There was a problem hiding this comment.
While efficiency and optimization, is important, having readable and understandable code is also very important. This includes using proper indentation and leaving the right amount of whitespace and newlines after expressions.
Member
|
Hey there! Thanks for your contribution 😄 The code is much shorter now, but is it not up to our standards. We use Doxygen-generated documentation for educational purposes so that other people can learn from the algorithms and implementations. I'm sorry, but I'll have to be closing this PR. Don't hesitate to join our Discord community to talk about algorithms, hang with other people, and more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
References
Checklist
Notes: