refactor: Refactored calculateMaxOfMin() (#5)#2957
refactor: Refactored calculateMaxOfMin() (#5)#2957chubretovic wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
| </plugins> | ||
| </build> | ||
| </project> No newline at end of file | ||
| </project> No newline at end of file |
There was a problem hiding this comment.
| </project> | |
| </project> | |
siriak
left a comment
siriak
left a comment
There was a problem hiding this comment.
Looks good, only a couple of comments
| int[] arr = new int[]{10, 20, 30, 50, 10, 70, 30}; | ||
| int[] target = new int[]{70, 30, 20, 10, 10, 10, 10}; | ||
| int[] res = calculateMaxOfMin(arr, arr.length); | ||
| assert Arrays.equals(target, res); | ||
| //assert Arrays.equals(target, res); |
| // Print the result | ||
| for (int i = 1; i <= n; i++) { | ||
| System.out.println(); | ||
| System.out.print("ans: "); | ||
| for (int i = 0; i < n; i++) { | ||
| System.out.print(ans[i] + " "); | ||
| } |
There was a problem hiding this comment.
Please remove printing the result
| } | ||
|
|
||
| } | ||
| } No newline at end of file |
|
And please update to the latest master |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Can I work under this issue? |
|
Can I work under this issue? |
|
@siddhant2002 yes, you can |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
3 participants
Refactored the function calcultateMaxOfMin form the class MaximinumMinimumWindow.