Implemented Fast Inverse Sqrt Method#3199
Closed
Conversation
siriak
requested changes
Jul 24, 2022
Member
siriak
left a comment
There was a problem hiding this comment.
The code looks good, could you add some automated tests as well?
Author
I have just pushed my latest commit that consists of automated tests between both methods |
Member
|
Take a look at the files here https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms, |
Contributor
|
Can I work under this issue? |
Contributor
|
@siriak Please check the pr |
Member
|
@siddhant2002 which PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
References
Checklist:
Fixes: #{$ISSUE_NO}.