Skip to content

Fixes: #3324 Use GCM (Galois Counter Mode) mode #3325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
siriak merged 3 commits into from
Oct 18, 2022
Merged

Fixes: #3324 Use GCM (Galois Counter Mode) mode #3325

siriak merged 3 commits into from
Oct 18, 2022

Conversation

@kongleong86
Copy link
Contributor

@kongleong86 kongleong86 commented Oct 1, 2022

Describe your change:

Fixes: #3324

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@kongleong86
Use GCM (Galois Counter Mode) mode for as ECB (Electronic Codebook) c…
1200186 
…ipher mode doesn’t provide serious message confidentiality
siriak
siriak requested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts

@kongleong86
Copy link
Contributor Author

kongleong86 commented Oct 17, 2022

Please resolve the conflicts
Conflicts resolved.

@kongleong86 kongleong86 requested a review from siriak October 17, 2022 17:04
siriak
siriak approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit f2e0126 into TheAlgorithms:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ECB cipher mode in AESEncryption doesn’t provide serious message confidentiality.

2 participants

@kongleong86 @siriak