Octal To Binary Conerter#4202
Merged
siriak merged 7 commits intoTheAlgorithms:masterfrom May 30, 2023
BamaCharanChhandogi:OctalToBinary
Merged
Octal To Binary Conerter#4202siriak merged 7 commits intoTheAlgorithms:masterfrom BamaCharanChhandogi:OctalToBinary
siriak merged 7 commits intoTheAlgorithms:masterfrom
BamaCharanChhandogi:OctalToBinary
Conversation
BamaCharanChhandogi
requested review from
debasishbsws,
siriak and
yanglbme
as code owners
debasishbsws
requested changes
May 28, 2023
Member
debasishbsws
left a comment
debasishbsws
left a comment
There was a problem hiding this comment.
Add some JUnit tests, for reference see https://github.com/TheAlgorithms/Java/blob/master/src/test/java/com/thealgorithms/conversions/OctalToDecimalTest.java
Member
Author
|
Hello @debasishbsws, I have updated the code and added test cases. |
siriak
requested changes
May 28, 2023
siriak
reviewed
May 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
octal To Binary Converter in Java.