Skip to content

style: make FindMin a proper utilty class #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2023
Merged

style: make FindMin a proper utilty class #4397

merged 2 commits into from
Sep 24, 2023

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Sep 24, 2023

Makes the class FindMin a proper utility class and does some basic linting.

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.

@vil02 vil02 mentioned this pull request Sep 24, 2023
Merged
5 tasks
@BamaCharanChhandogi
Copy link
Member

BamaCharanChhandogi commented Sep 24, 2023

There are a lot of files that are needed to test cases in the Math section.
Like Find Max or Min etc.

@vil02
Copy link
Member Author

vil02 commented Sep 24, 2023

There are a lot of files that are needed to test cases in the Math section. Like Find Max or Min etc.

FindMin and FindMax are tested (cf. FindMinTest, FindMaxTest).

Regarding the rest: yes, there are lots of classes, which need tests.

siriak
siriak approved these changes Sep 24, 2023
View reviewed changes
Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak enabled auto-merge (squash) September 24, 2023 10:23
@siriak siriak merged commit d6024f9 into TheAlgorithms:master Sep 24, 2023
@vil02 vil02 deleted the make_FindMin_proper_utility branch September 24, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siriak siriak siriak approved these changes

@yanglbme yanglbme Awaiting requested review from yanglbme yanglbme is a code owner

@debasishbsws debasishbsws Awaiting requested review from debasishbsws

@BamaCharanChhandogi BamaCharanChhandogi Awaiting requested review from BamaCharanChhandogi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vil02 @BamaCharanChhandogi @siriak