-
Notifications
You must be signed in to change notification settings - Fork 20.7k
refactor: Enhance docs, add tests in PrintMatrixInSpiralOrder
#6636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Enhance docs, add tests in PrintMatrixInSpiralOrder
#6636
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6636 +/- ##
============================================
- Coverage 78.00% 77.98% -0.03%
+ Complexity 6444 6436 -8
============================================
Files 737 736 -1
Lines 21519 21499 -20
Branches 4208 4201 -7
============================================
- Hits 16785 16765 -20
- Misses 4062 4063 +1
+ Partials 672 671 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! @Hardvan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hardvan
I found that there are multiple PrintAMatrixInSpiralOrder classes:
com.thealgorithms.matrix.PrintAMatrixInSpiralOrdercom.thealgorithms.others.PrintAMatrixInSpiralOrder
Please remove the duplicate class in the others package and ensure that only one class remains in the matrix package.
Also, move your updated class (with improved documentation) and the corresponding test file into the matrix package so at the end there exists only one class in the matrix folder
|
@DenizAltunkapan Done |
|
Thanks @Hardvan. Please merge from master to merge this pr. |
|
@Hardvan Please resolve the conficts |
clang-format -i --style=file path/to/your/file.java