Skip to content

Conversation

@Hardvan
Copy link
Contributor

@Hardvan Hardvan commented Oct 5, 2025

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.98%. Comparing base (8930369) to head (fcd04d7).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6636      +/-   ##
============================================
- Coverage     78.00%   77.98%   -0.03%     
+ Complexity     6444     6436       -8     
============================================
  Files           737      736       -1     
  Lines         21519    21499      -20     
  Branches       4208     4201       -7     
============================================
- Hits          16785    16765      -20     
- Misses         4062     4063       +1     
+ Partials        672      671       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! @Hardvan

Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hardvan
I found that there are multiple PrintAMatrixInSpiralOrder classes:

Please remove the duplicate class in the others package and ensure that only one class remains in the matrix package.
Also, move your updated class (with improved documentation) and the corresponding test file into the matrix package so at the end there exists only one class in the matrix folder

@Hardvan
Copy link
Contributor Author

Hardvan commented Oct 12, 2025

@DenizAltunkapan Done

@DenizAltunkapan DenizAltunkapan enabled auto-merge (squash) October 12, 2025 09:06
@DenizAltunkapan
Copy link
Member

DenizAltunkapan commented Oct 12, 2025

Thanks @Hardvan. Please merge from master to merge this pr.

@DenizAltunkapan
Copy link
Member

@Hardvan Please resolve the conficts

@DenizAltunkapan DenizAltunkapan merged commit f66da5e into TheAlgorithms:master Oct 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants