Skip to content

Conversation

@koushik-sai
Copy link
Contributor

  • Added a recursive implementation of factorial in the recursion package
  • Followed utility-class pattern used across the repository
  • Included JUnit tests for base cases, positive input, and negative input

@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.90%. Comparing base (1eb0d61) to head (267ae5f).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #7178   +/-   ##
=========================================
  Coverage     78.90%   78.90%           
  Complexity     6864     6864           
=========================================
  Files           772      772           
  Lines         22697    22697           
  Branches       4459     4459           
=========================================
  Hits          17908    17908           
  Misses         4073     4073           
  Partials        716      716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan
Copy link
Member

DenizAltunkapan commented Dec 19, 2025

there already exists a recursive implementation @koushik-sai https://github.com/TheAlgorithms/Java/blob/master/src/main/java/com/thealgorithms/maths/FactorialRecursion.java .
Would you suggest moving the existing class into the recursive package?
If so, please move it there and remove your implementation.

@koushik-sai
Copy link
Contributor Author

Thanks for the suggestion 👍
I’ve moved the existing FactorialRecursion from the maths package to the recursion package, removed the duplicate implementation introduced in this PR, updated the corresponding tests, and applied clang-format. All tests pass locally.

Copy link
Member

@DenizAltunkapan DenizAltunkapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @koushik-sai

@DenizAltunkapan DenizAltunkapan enabled auto-merge (squash) December 22, 2025 20:14
@DenizAltunkapan DenizAltunkapan merged commit 2707da2 into TheAlgorithms:master Dec 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants