-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Added FindMax to Maths #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e17e0d0
Added FindMax to Maths
JadenLeake333 79a2b16
Added FindMax to Maths
JadenLeake333 7ae8d92
Added FindMax
JadenLeake333 58bd7f4
Added FindMax to Maths
JadenLeake333 4e34c7d
Add FindMax test
JadenLeake333 fa2186b
Fix
JadenLeake333 af752e9
Styling errors
JadenLeake333 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /** | ||
| * Function to find the maximum number given an array of integers | ||
| * Returns the maximum number of the array | ||
| * If the array is empty it returns the string 'Array is empty' | ||
| */ | ||
|
|
||
| export const findMax = (arr) => { | ||
| if (arr.length === 0) { return 'Array is empty' } | ||
|
|
||
| let max = arr[0] | ||
| arr.forEach(element => { | ||
| if (element > max) { | ||
| max = element | ||
| } | ||
| }) | ||
| return max | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { findMax } from '../FindMax' | ||
|
|
||
| test('Should return the highest number in the array', () => { | ||
| const max = findMax([2, 5, 1, 12, 43, 1, 9]) | ||
| expect(max).toBe(43) | ||
| }) | ||
|
|
||
| test('Should return the highest number in the array', () => { | ||
| const max = findMax([21, 513, 6]) | ||
| expect(max).toBe(513) | ||
| }) | ||
|
|
||
| test('Should return the highest number in the array', () => { | ||
| const max = findMax([]) | ||
| expect(max).toBe('Array is empty') | ||
| }) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throw an error, not a string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @raklaptudirm. Whenever you know the conditions where your function will fail (I call them nice errors) then throw then instead of handling them yourself (by returning a string) throw an error instead so that the user can handled them according to their business rules.