Skip to content

style: use $HOME in nim path #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2023
Merged

style: use $HOME in nim path #54

merged 2 commits into from
Sep 1, 2023

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Aug 7, 2023

This PR simplifies the .gitpod.dockerfile by using $HOME for constructing the path, where nim is.

@vil02 vil02 requested a review from Panquesito7 as a code owner August 7, 2023 20:09
@vil02 vil02 changed the title style: use /home/gitpod in nim path style: use $HOME in nim path Aug 7, 2023
Panquesito7
Panquesito7 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Thanks! 🚀

@Panquesito7 Panquesito7 added the enhancement New feature or request label Sep 1, 2023
@Panquesito7 Panquesito7 merged commit 0d1ab42 into TheAlgorithms:main Sep 1, 2023
@vil02 vil02 deleted the use_home_in_gitpod_dockerfile branch September 1, 2023 16:09
@vil02
Copy link
Member Author

vil02 commented Sep 1, 2023

@Panquesito7 thanks for the merge. Long time no see.

@Panquesito7
Copy link
Member

Panquesito7 commented Sep 1, 2023

@Panquesito7 thanks for the merge. Long time no see.

Yeah, it's been a while! Slowly coming back. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vil02 @Panquesito7