Skip to content

Added doctest and changing the code to return list in dynamic_programming/subset_generation.py.#10186

Closed
AasheeshLikePanner wants to merge 3 commits into
TheAlgorithms:masterfrom
AasheeshLikePanner:master
Closed

Added doctest and changing the code to return list in dynamic_programming/subset_generation.py.#10186
AasheeshLikePanner wants to merge 3 commits into
TheAlgorithms:masterfrom
AasheeshLikePanner:master

Conversation

@AasheeshLikePanner
Copy link
Copy Markdown
Contributor

@AasheeshLikePanner AasheeshLikePanner commented Oct 9, 2023

Describe your change:

Added doctest and changing the code to return list in dynamic_programming/subset_generation.py.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 9, 2023
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 9, 2023
@cclauss
Copy link
Copy Markdown
Member

cclauss commented Oct 9, 2023

Please do not change the code and the tests in a single pull request. It is too difficult to review (especially when we have >180 open pull requests.

The proper way to do this is to create pull request that ONLY adds tests.
AFTER the first pull request is merged then create a second pull request that changes the code.

@cclauss cclauss closed this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants