Skip to content

Implement MinStack with O(1) get_min using two stacks in Python#13059

Open
Rishabhsaini21 wants to merge 7 commits intoTheAlgorithms:masterfrom
Rishabhsaini21:Rishabhsaini21-fixedcode
Open

Implement MinStack with O(1) get_min using two stacks in Python#13059
Rishabhsaini21 wants to merge 7 commits intoTheAlgorithms:masterfrom
Rishabhsaini21:Rishabhsaini21-fixedcode

Conversation

@Rishabhsaini21
Copy link

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.(https://en.wikipedia.org/wiki/Stack_(abstract_data_type))
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

Rishabhsaini21 and others added 5 commits October 1, 2025 19:44
Implemented a new Minstack class which works like a stack and gives minimum  of stack  in O(1) using an extra auxiliary stack
…acks/min_stack_with_twostacks

Moved minstack from data structures folder to stack folder as it is part of that folder
Refactor MinStack: add type hints ,return type,  snake_case, and doctests which were missing.
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Oct 1, 2025
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant