Divide and Conquer #1308
Divide and Conquer #1308
Conversation
maths/find_max_recursion.py
Outdated
| :param nums: contains elements | ||
| :param left: index of first element | ||
| :param right: index of last element | ||
| :return: min in nums |
There was a problem hiding this comment.
:return: says min but should say max.
Also, add doctests as discussed in CONTRIBUTING.md
>>> nums = [1, 3, 5, 7, 9, 2, 4, 6, 8, 10]
>>> find_max(nums, 0, len(nums) - 1) = max(nums)
TrueThere was a problem hiding this comment.
Both files need doctests like the one above.
There was a problem hiding this comment.
:return: says min but should say max.
Also, add doctests as discussed in CONTRIBUTING.md
>>> nums = [1, 3, 5, 7, 9, 2, 4, 6, 8, 10] >>> find_max(nums, 0, len(nums) - 1) = max(nums) True
I updated as you say, correct?
maths/find_max_recursion.py
Outdated
| :param right: index of last element | ||
| :return: max in nums | ||
|
|
||
| >>find_max([1, 3, 5, 7, 9, 2, 4, 6, 8, 10], 0, 9) == 10 |
There was a problem hiding this comment.
greater than >, greater than >, greater than >, space
If not, it is not recognizing as a test.
There was a problem hiding this comment.
you mean like this nums = [9, 7, 5, 3, 2, 1] ?
There was a problem hiding this comment.
Nope. I mean:
>>> find_max(...
# not...
>>find_max(...There was a problem hiding this comment.
So that your tests appear here https://travis-ci.org/TheAlgorithms/Python/builds/595103352#L382
There was a problem hiding this comment.
Thanks, I corrected follow as you say.
|
Please review again @cclauss |
maths/find_max_recursion.py
Outdated
| :return: max in nums | ||
| """ | ||
|
|
||
| """ |
| :param right: index of last element | ||
| :return: min in nums | ||
| """ | ||
|
|
|
Please review again! @cclauss |
|
@cclauss Did you forget review?😹 |
Thanks for your persistence!
2 participants
Find max and min value using Divide and Conquer algorithms