Fix: Ensure consistent error handling in coordinate_compression.py#13457
Open
prem-2006 wants to merge 8 commits intoTheAlgorithms:masterfrom
Open
Fix: Ensure consistent error handling in coordinate_compression.py#13457prem-2006 wants to merge 8 commits intoTheAlgorithms:masterfrom
prem-2006 wants to merge 8 commits intoTheAlgorithms:masterfrom
Conversation
Updated compress() and decompress() methods to raise ValueError when given invalid or missing values instead of silently returning -1. This ensures consistent and predictable behavior across all methods, prevents silent failures, and improves debugging clarity. Resolves Issue TheAlgorithms#13226
Updated the CoordinateCompressor class to improve clarity and functionality, including better error handling and documentation.
Refactor CoordinateCompressor for clarity and functionality
for more information, see https://pre-commit.ci
Updated docstrings for clarity and conciseness.
Add a newline at the end of the file for consistency.
Add newline at end of coordinate_compression.py
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated compress() and decompress() methods to raise ValueError when given invalid or missing values instead of silently returning -1.
This ensures consistent and predictable behavior across all methods, prevents silent failures, and improves debugging clarity.
Resolves Issue #13226
Describe your change:
Checklist: