Add five logic building problems to logic_building_problems directory #13663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement FizzBuzz function with input validation and examples.
This module provides a function to check if a string is a palindrome, including examples and doctest integration.
This module includes a function to check if a string is a pangram, with examples provided in the docstring.
This module includes functions for finding the maximum, minimum, and sum of elements in an array, with appropriate error handling and examples.
This module implements the bubble sort algorithm, which sorts a list by repeatedly swapping adjacent elements that are in the wrong order. It includes a function with examples demonstrating its usage.
algorithms-keeper
bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
logic_building_problems/fizz_buzz.py
Outdated
| """ | ||
|
|
||
|
|
||
| def fizz_buzz(n: int) -> list[str]: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
for more information, see https://pre-commit.ci
…ort.py Removed unnecessary range start in bubble sort loop.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
logic_building_problems/fizz_buzz.py
Outdated
| """ | ||
|
|
||
|
|
||
| def fizz_buzz(n: int) -> list[str]: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
Updated docstring formatting for clarity.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
logic_building_problems/fizz_buzz.py
Outdated
| """ | ||
|
|
||
|
|
||
| def fizz_buzz(n: int) -> list[str]: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
logic_building_problems/fizz_buzz.py
Outdated
| """ | ||
|
|
||
|
|
||
| def fizz_buzz(n: int) -> list[str]: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
Updated doctest for fizz_buzz function to normalize whitespace in output.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
logic_building_problems/fizz_buzz.py
Outdated
| """ | ||
|
|
||
|
|
||
| def fizz_buzz(n: int) -> list[str]: |
There was a problem hiding this comment.
Please provide descriptive name for the parameter: n
algorithms-keeper
bot
removed
the
require descriptive names
for more information, see https://pre-commit.ci
This was referenced Oct 22, 2025
algorithms-keeper
bot
removed
the
tests are failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Summary:
This PR adds five new logic building problems to the
logic_building_problemsdirectory:All implementations include:
Checklist: