Skip to content

Fix: add actual implementation for use-effect simulation (previous PR was empty)#14518

Open
kadambari25 wants to merge 4 commits intoTheAlgorithms:masterfrom
kadambari25:use-effect-example
Open

Fix: add actual implementation for use-effect simulation (previous PR was empty)#14518
kadambari25 wants to merge 4 commits intoTheAlgorithms:masterfrom
kadambari25:use-effect-example

Conversation

@kadambari25
Copy link
Copy Markdown

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests?
  • Documentation change?

This PR corrects a previous submission where the file was unintentionally empty.

A proper implementation has now been added for simulating "useEffect"-like behavior in Python. The function executes a callback when a dependency changes, demonstrating a basic reactive programming concept.

The implementation includes:

  • Type hints for better readability
  • Doctests for validation
  • Documentation explaining the approach

Reference:
https://en.wikipedia.org/wiki/Reactive_programming

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file.
  • All new Python files are placed inside an existing directory.
  • All filenames are in lowercase.
  • All functions follow Python naming conventions.
  • All function parameters and return values are annotated with type hints.
  • All functions have doctests.
  • All new algorithms include a reference URL.
  • Fixes use effect #14299

@algorithms-keeper algorithms-keeper bot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Apr 7, 2026
Copy link
Copy Markdown

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.



if __name__ == "__main__":
def example():
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: example. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file dynamic_programming/use_effect_simulation.py, please provide doctest for the function example

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Apr 7, 2026
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use effect

3 participants