Simplify bin_to_hexadecimal function#14570
Open
Ewanjohndennis wants to merge 2 commits intoTheAlgorithms:masterfrom
Open
Simplify bin_to_hexadecimal function#14570Ewanjohndennis wants to merge 2 commits intoTheAlgorithms:masterfrom
Ewanjohndennis wants to merge 2 commits intoTheAlgorithms:masterfrom
Conversation
Rewrote bin_to_hexadecimal to use Python's built-in int(s, 2) and hex() instead of a manual lookup table and bit-grouping loop. The old approach had a padding bug: inputs whose length was already a multiple of 4 got an extra 4 zeros prepended, so '1010' came out as '0x0a' instead of '0xa'. The new approach skips padding entirely and lets the stdlib handle it correctly. Also added a guard for "-" as input, which previously slipped past the empty-string check and raised an unhelpful ValueError about non-binary values. Removes BITS_TO_HEX, the divmod padding expression, and the grouping loop. Doctests updated to reflect the corrected output.
for more information, see https://pre-commit.ci
algorithms-keeper
bot
added
awaiting reviews
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrote
bin_to_hexadecimalto use Python's built-inint(s, 2)andhex()instead of a manual lookup table and bit-grouping loop. The old approach had a padding bug: inputs whose length was already a multiple of 4 got an extra 4 zeros prepended, so'1010'came out as'0x0a'instead of'0xa'. The new approach skips padding entirely and lets the stdlib handle it correctly. Also added a guard for"-"as input, which previously slipped past the empty-string check and raised an unhelpfulValueErrorabout non-binary values.Describe your change:
Checklist: