Skip to content

fix: raise ValueError for multi-character separator in split#14667

Open
SAY-5 wants to merge 1 commit into
TheAlgorithms:masterfrom
SAY-5:fix-split-multichar-separator
Open

fix: raise ValueError for multi-character separator in split#14667
SAY-5 wants to merge 1 commit into
TheAlgorithms:masterfrom
SAY-5:fix-split-multichar-separator

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented May 12, 2026

Describe your change:

strings/split.py previously iterated character by character comparing each char to separator, so any multi-character separator silently failed to match and the whole string was returned as a single element.

Now split validates len(separator) == 1 up front and raises ValueError("separator must be a single character") when it isn't, matching the actual capability of the implementation. Added a doctest covering the new error path.

Fixes #14649

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: Fixes #ISSUE-NUMBER.

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split silently returns wrong result for multi-character separators

1 participant