fix: raise ValueError when run_simplex exhausts maxiter#14669
Open
SAY-5 wants to merge 2 commits into
Open
Conversation
Fixes TheAlgorithms#14584 Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Tableau.run_simplexwas silently returning an empty dict{}after exhaustingTableau.maxiteriterations, making it impossible for callers to tell convergence failure apart from a problem whose optimum is genuinely all-zero. The empty-dict path also masked cycling/unboundedness.Now it raises
ValueErrorwith the iteration limit so the caller gets an actionable signal. All existing doctests still pass.Fixes #14584
Checklist:
Fixes #ISSUE-NUMBER.