Skip to content

fix: raise ValueError when run_simplex exhausts maxiter#14669

Open
SAY-5 wants to merge 2 commits into
TheAlgorithms:masterfrom
SAY-5:fix-simplex-maxiter-silent-fail
Open

fix: raise ValueError when run_simplex exhausts maxiter#14669
SAY-5 wants to merge 2 commits into
TheAlgorithms:masterfrom
SAY-5:fix-simplex-maxiter-silent-fail

Conversation

@SAY-5
Copy link
Copy Markdown

@SAY-5 SAY-5 commented May 12, 2026

Describe your change:

Tableau.run_simplex was silently returning an empty dict {} after exhausting Tableau.maxiter iterations, making it impossible for callers to tell convergence failure apart from a problem whose optimum is genuinely all-zero. The empty-dict path also masked cycling/unboundedness.

Now it raises ValueError with the iteration limit so the caller gets an actionable signal. All existing doctests still pass.

Fixes #14584

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: Fixes #ISSUE-NUMBER.

Fixes TheAlgorithms#14584

Signed-off-by: SAY-5 <say.apm35@gmail.com>
@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels May 12, 2026
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: run_simplex() returns empty dict {} on max iteration instead of raising an informative error

1 participant