Add type hints to pancake_sort (#14737)#14880
Open
shreya-learn-explores wants to merge 7 commits into
Open
Conversation
diusazzad
suggested changes
Jun 30, 2026
diusazzad
left a comment
There was a problem hiding this comment.
Great job fixing those type hints! Really appreciate the effort.
Before we can merge this, can you make these quick tweaks to line up with our contributing guidelines?Put from future import annotations right at the top.Strip out the input() prompts from lines 38-42. We want to avoid manual inputs and stick to doctest.testmod().Optional but great to have: please add the Time (O(n^2)) and Space (O(n)) complexities inside the docstring.Thanks again, keep it up
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This pull request adds missing type hints to the
pancake_sortfunction insorts/pancake_sort.py.Changes made:
MutableSequenceimport fromcollections.abcarrparameterThis improves code readability and consistency with the repository's type hinting standards.
Checklist: