Skip to content

Fixed bug with incorrect LU decomposition #2261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 2 commits into from
Aug 1, 2020
Merged

Fixed bug with incorrect LU decomposition #2261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e1e213
Fixed Bug #2257
Aug 1, 2020
281c452
=
cclauss Aug 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions arithmetic_analysis/lu_decomposition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ def LUDecompose(table):
if rows != columns:
return []
for i in range(columns):
for j in range(i - 1):
for j in range(i):
sum = 0
for k in range(j - 1):
for k in range(j):
sum += L[i][k] * U[k][j]
L[i][j] = (table[i][j] - sum) / U[j][j]
L[i][i] = 1
for j in range(i - 1, columns):
for j in range(i, columns):
sum1 = 0
for k in range(i - 1):
for k in range(i):
sum1 += L[i][k] * U[k][j]
U[i][j] = table[i][j] - sum1
return L, U
Expand Down
2 changes: 1 addition & 1 deletion arithmetic_analysis/newton_method.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def newton(function: RealFunc, derivative: RealFunc, starting_int: int,) -> floa
...
ZeroDivisionError: Could not find root
"""
prev_guess float(starting_int)
prev_guess = float(starting_int)
while True:
try:
next_guess = prev_guess - function(prev_guess) / derivative(prev_guess)
Expand Down