Skip to content

Added type hints and doctest for maths/prime_check. #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cclauss merged 2 commits into from
Aug 29, 2020
Merged

Added type hints and doctest for maths/prime_check. #2367

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44dc750
Added type hints and doctest for maths/prime_check.
frangiz Aug 29, 2020
057aeda
Removed doctests.
frangiz Aug 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions maths/prime_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import unittest


def prime_check(number):
def prime_check(number: int) -> bool:
"""
Check to See if a Number is Prime.

Expand Down Expand Up @@ -42,7 +42,7 @@ def test_primes(self):
def test_not_primes(self):
self.assertFalse(prime_check(-19), "Negative numbers are not prime.")
self.assertFalse(
prime_check(0), "Zero doesn't have any divider, primes must have two"
prime_check(0), "Zero doesn't have any divider, primes must have two."
)
self.assertFalse(
prime_check(1), "One just have 1 divider, primes must have two."
Expand Down