Skip to content

adding the array_complement method #6325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
meg-1 wants to merge 3 commits into from
Closed

adding the array_complement method #6325

meg-1 wants to merge 3 commits into from

Conversation

@meg-1
Copy link
Contributor

@meg-1 meg-1 commented Aug 13, 2022

Describe your change:

removes all values from list a which are also present in list b [ while keeping the initial order of the elements ]

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Aug 13, 2022
@ghost ghost removed the tests are failing Do not merge until tests pass label Aug 17, 2022
@meg-1
Copy link
Contributor Author

meg-1 commented Aug 27, 2022

@poyea hi! could you please check out this pull request??

1 similar comment
@meg-1
Copy link
Contributor Author

meg-1 commented Sep 3, 2022

@poyea hi! could you please check out this pull request??

poyea
poyea reviewed Sep 14, 2022
View reviewed changes
boolean_algebra/array_complement.py

"""

return [c for c in initial_lst if c not in diff_lst]
Copy link
Member

@poyea poyea Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like boolean_algebra. This could be in array? if there's any update possible to existing code

Copy link
Contributor Author

@meg-1 meg-1 Sep 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the suggestion! sounds like a nice idea! would it be okay if i create a new "array" folder in the repo for this? or did you mean that there might be a smilar folder, which exists already, and i should add this algorithm to it? if so, could you please direct me to it?

@meg-1 meg-1 closed this by deleting the head repository Oct 5, 2022
@meg-1 meg-1 mentioned this pull request Oct 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@poyea poyea poyea left review comments

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@meg-1 @poyea