Skip to content

polynomial_degree1_root#7990

Closed
JH-UCLouvain wants to merge 2 commits intoTheAlgorithms:masterfrom
JH-UCLouvain:patch-2
Closed

polynomial_degree1_root#7990
JH-UCLouvain wants to merge 2 commits intoTheAlgorithms:masterfrom
JH-UCLouvain:patch-2

Conversation

@JH-UCLouvain
Copy link

@JH-UCLouvain JH-UCLouvain commented Nov 15, 2022

Describe your change:

Add a method to the existing Polynomial class that returns the root of a degree 1 polynomial.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 15, 2022
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Nov 15, 2022
@JH-UCLouvain JH-UCLouvain closed this by deleting the head repository Nov 16, 2022
@JH-UCLouvain JH-UCLouvain reopened this Nov 16, 2022
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant