-
-
Notifications
You must be signed in to change notification settings - Fork 46
Make the formatter script an action #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Panquesito7 This is what I was talking about. The usage is quite straight forward now, you just have to just add these in the workflow file as a step - this won't commit the changes like jobs:
formatter:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: ./formatter
with:
filetypes: .cpp,.hpp
working-directory: . |
|
I'll work tomorrow on making the |
| @@ -0,0 +1,13 @@ | |||
| name: Test | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably merge both workflows and have them in one place to make things shorter/cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge them then if either one of them fails, we won't know until we dig deeper which scenario failed. I prefer to keep them separate so I can just glance and know which one failed, if that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With multiple jobs, we can see which one passed or not in the same workflow. It'll be longer but can be easier to check, IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider this: if we have two of these (let's call A and B) then when we have them in the same file, there must be an order which must be followed. Say first A then B - in this scenario, if A fails we don't know whether B is working as expected because the whole workflow stops execution. That's why I'm against it, and unless you're worried about the runner costs here, I think it should be okay to keep them separate... What do you think? I can place them in a single file easily just wanted to note this caveat before I do and ask your opinion on it.
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks! 🚀
A simple transformation to make the formatter script as an action that would be made reusable by using the actions api without relying on
wget