Customizable engine-type combobox for vehicles#72
Merged
TheAngryRaven merged 1 commit intoMay 27, 2026
Conversation
Replace the vehicle form's free-text Engine input with a searchable combobox backed by a reusable, per-user engine list. Users type to filter previously saved engines and create new ones inline when no match exists. Existing vehicles' engine names are auto-imported, and a "manage" link opens a small delete-only menu (engines in use by a vehicle are protected from deletion). Engines persist in a new IndexedDB store (db v10) and emit garage change events so they ride along with the rest of the garage over cloud sync. Pure search/dedup logic lives in engineUtils with tests. https://claude.ai/code/session_014aFrVH8nLTmVuRHhAU4gmt
Coverage SummaryLines: 37.12% (2333/6284) · Statements: 36.07% · Functions: 30.31% · Branches: 37.83% Per-file coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the vehicle form's plain free-text Engine input with a searchable combobox backed by a reusable, per-user engine list:
engines, DB v10) and emit garage change events, so they ride along with the rest of the garage over cloud sync (added tosyncStores).Pure search / dedup / create-offer logic lives in
engineUtils.tswith full Vitest coverage. The combobox lands in the lazyFileManagerDrawerchunk, keeping it off the initial bundle path.Files
lib/dbUtils.ts— bump DB version 9→10, newenginesstorelib/engineStorage.ts(new) — IndexedDB CRUD + garage eventslib/engineUtils.ts(new) +engineUtils.test.ts(new) — pure helpers + testshooks/useEngineManager.ts(new) — list/add/import/removecomponents/drawer/EngineCombobox.tsx(new) — searchable field + manage dialogcomponents/drawer/VehiclesTab.tsx— wire in the combobox + auto-importplugins/cloud-sync/syncStores.ts— sync theenginesstoreCHANGELOG.md,CLAUDE.md— docsTest plan
npm run lint— cleannpm run typecheck— cleannpm run test:run— 706 passing (incl. newengineUtilstests)npm run build— succeedshttps://claude.ai/code/session_014aFrVH8nLTmVuRHhAU4gmt
Generated by Claude Code