Load lap snapshots as the reference lap#74
Merged
Conversation
Selecting a snapshot already routed it into the reference-overlay slot, but it wasn't discoverable as "the reference" and had no entry point on the lap page. - The Snapshots menu now reads "Load as reference lap" and selecting a snapshot sets it as the reference comparison. - Add a "Load snapshot as reference" button next to the external-reference loader (Choose Log) on the lap times page, opening the same per-course snapshot picker in load-only mode. Threaded through SessionContext + ExternalRefBar's new trailing slot. https://claude.ai/code/session_01L9h3QDcyTEXmVe6tWMio6T
Coverage SummaryLines: 35.59% (2397/6734) · Statements: 34.62% · Functions: 28.99% · Branches: 36.17% Per-file coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the lap-snapshots feature (#73): make loading a snapshot as the reference lap discoverable, and add an entry point on the lap times page.
Selecting a snapshot already routed its clean lap into the reference-overlay slot (so it renders as the comparison and stays out of playback/video) — but it wasn't obvious that this is setting the reference, and there was no way to reach it from the lap page next to the existing external-reference loader.
Changes
ExternalRefBargrew atrailingslot;LapSnapshotControlsgainedtriggerLabel+showSaveprops; snapshot state is exposed throughSessionContextso the lap page can render the picker.Files
LapSnapshotControls.tsx,ExternalRefBar.tsx,LapTable.tsx,tabs/LapTimesTab.tsx,contexts/SessionContext.tsx,pages/Index.tsx,CHANGELOG.md.Test plan
npm run lint,npm run typecheck,npm run test:run(737 passing),npm run buildall greenhttps://claude.ai/code/session_01L9h3QDcyTEXmVe6tWMio6T
Generated by Claude Code