Add fallback integration for DwarFS AppImages and improve desktop shortcut handling#771
Open
kahikara wants to merge 5 commits intoTheAssassin:masterfrom
Open
Add fallback integration for DwarFS AppImages and improve desktop shortcut handling#771kahikara wants to merge 5 commits intoTheAssassin:masterfrom
kahikara wants to merge 5 commits intoTheAssassin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an extraction based fallback when the normal libappimage integration path fails, which allows AppImages like Eden to integrate successfully.
It also improves desktop shortcut behavior so shortcuts are only auto created once and are not recreated after being deleted manually. Cleanup now removes managed shortcuts and fallback launcher paths correctly.
In addition, fallback icon resolution was improved for extracted AppDirs, including dotted icon names.
The settings dialog was also polished so its action buttons show proper icons or visible fallback text instead of appearing empty.